Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use async/await for internal readAsync function. NFC #23120

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Use async/await for internal readAsync function. NFC #23120

merged 1 commit into from
Dec 13, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Dec 10, 2024

Followup to #23104.

sbc100
sbc100 commented Dec 10, 2024
View reviewed changes
src/shell.js Show resolved Hide resolved
@sbc100 sbc100 force-pushed the readAsync branch 3 times, most recently from 90b6983 to 8bf08af Compare December 10, 2024 23:09
@sbc100 sbc100 enabled auto-merge (squash) December 10, 2024 23:21
kripken
kripken approved these changes Dec 10, 2024
View reviewed changes
src/node_shell_read.js Show resolved Hide resolved
@sbc100 sbc100 force-pushed the readAsync branch 2 times, most recently from e8830f6 to d8f2a2d Compare December 12, 2024 20:43
@sbc100 sbc100 disabled auto-merge December 13, 2024 02:38
@sbc100 sbc100 merged commit 1092ec3 into emscripten-core:main Dec 13, 2024
26 of 28 checks passed
@sbc100 sbc100 deleted the readAsync branch December 13, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

@brendandahl brendandahl Awaiting requested review from brendandahl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken